Renamed Vector2.tangent to perpendicular #39685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is still "Returns a perpendicular vector", and it seems a bit strange for the only description to be the same as the name of the method. We may as well take this opportunity to update the documentation to be more descriptive. Specifically, it should note that the resulting vector is rotated 90 degrees counter-clockwise compared to the original, with the same length. |
83 tasks
aaronfranke
force-pushed
the
tangent_rename
branch
from
9a73594 to
5325d4b
Compare
aaronfranke
approved these changes
Sep 3, 2020
Chaosus
force-pushed
the
tangent_rename
branch
from
5325d4b to
4295988
Compare
aaronfranke
force-pushed
the
tangent_rename
branch
from
4295988 to
e3dbdcd
Compare
aaronfranke
force-pushed
the
tangent_rename
branch
from
e3dbdcd to
6e38279
Compare
|
Well, in the context of where it is used, it should not be ambiguous, so I am not sure about this rename. |
|
Superseded by #44149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the proposed renames from #16863 (comment)