Revert "Adds fuzzy search for help search dialog"

[follower]

This reverts commit 481dbce.

Current fuzzy search implementation results in too many
non-useful results.

Could be re-added after result sort/filter/score functionality
is added. See #30072 for example existing implementation.

Fixes: #39128

Reverts: #32043

Fixed format style conflicts:

• editor/editor_help_search.cpp

[follower]

Search term example screenshots:

• abs

  

• cache

  

• hex

  

• search

  

• stor

  

• store

  

• kin2 (no results due to removal of fuzzy search):

  

• nine (indicates exact match prefixes would still benefit from prioritisation):

  

[akien-mga]

Seems better to me to go back to the previous behavior indeed, I agree that the fuzzy search is not so useful (unless you know exactly what you're searching for and want to be able to find it even if you make typos, which I guess might have been @guilhermefelipecgs's motivation for #32043?).

[follower]

[Written at same time as @akien-mga's comment. :) ]

I think this is even more important in view of the significant and non-backwards 4.0 changes which will result in almost everyone not having experience with the changed functionality and potentially using help search more often.

I think ideally we could support fuzzy matching and have useful non-fuzzy results but obviously that's additional effort.

Also, wanted to ping @guilhermefelipecgs as the original author of the reverted commit as a courtesy & in case they wish to look at incorporating sort/filter/scoring functionality such as used in #30072. It would also be helpful to have more examples of "fuzzy" searches with the desired results to help with scoring/sorting of results.

Thanks!

[guilhermefelipecgs]

I agree that we need to add some type of scoring system to improve the search. When I implemented this I used it to speed up my queries, but I usually know what I'm looking for :)

[guilhermefelipecgs]

But I'm not sure how to improve this. I'll think about it.

[akien-mga]

Thanks!

[follower]

@guilhermefelipecgs If you do go down this path I'd strongly recommend looking at https://github.com/godotengine/godot/pull/30072/files which I'm sure could probably just be copied & pasted. ;)

Also useful starting points:

• Make editor help select shortest (best) instead of first match #13390
• Improve code completion search #5196

I suspect what may need to happen is that the existing semi-duplicated code performing similar filter/score/sorting processing could be extracted into a more generic helper.

[akien-mga]

Cherry-picked for 3.2.3.