[Reference PR] Attempt on adding mutli cursor to TextEdit #40195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Obvious ones fixed - TODO: rendering paired symbols - TODO: wrapped lines handling in _get_mouse_pos
|
According to #31739, Paulb23 is working on a refactor on TextEdit and the script editor nodes, which will likely make this PR incompatible with the final result. I'm going to abandon this PR for now, and leave this here for reference purposes. In case we find it useful later, I can always reopen it. |
|
Seems like #61902 is the more recent equivalent of this PR, so is there more to salvage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a multi cursor feature to TextEdit (very breaking compat)