Fixes the get_visible_line_count() of rich text label #40217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.2.3. |
akien-mga
removed
the
cherrypick:3.x
|
Reverted the cherry-pick for now until we figure out the #40982 regression. |
akien-mga
added
the
cherrypick:3.x
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18722
Bug:
get_visible_line_count()would return wrong values.Reason: While being drawn,
visible_line_countwas getting wrong values from_process_line(). Actually,_process_line()return wrong number ofnonblank_line_count. This was messing up thevisible_line_count.Fix: Every time a line is drawn,
visible_line_countis simply incremented, instead of getting wrong values from_process_line()Before Fix
After Fix