Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] [4.0] Simplify OS value retrieval #41172

Merged
merged 1 commit into from
Aug 11, 2020
Merged

[iOS] [4.0] Simplify OS value retrieval #41172

merged 1 commit into from
Aug 11, 2020

Conversation

naithar
Copy link
Contributor

@naithar naithar commented Aug 10, 2020 •
edited by akien-mga
Loading

Simplifies the way locale and unique_id is retrieved.
Also fixes locale returning incorrect parameters.

Issue related to locale, fixed #41058

locale also uses @bruvzg fix from #40708

@naithar naithar mentioned this pull request Aug 10, 2020
Merged
@Calinou Calinou added this to the 4.0 milestone Aug 10, 2020
@akien-mga akien-mga merged commit 69e995e into godotengine:master Aug 11, 2020
@akien-mga
Copy link
Member

Thanks!

@naithar naithar deleted the fix/iphone-os-values branch August 11, 2020 09:46
@akien-mga akien-mga mentioned this pull request Aug 11, 2020
Closed
@bruvzg bruvzg mentioned this pull request Aug 18, 2020
Closed
@naithar naithar mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement platform:ios topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Inconsistent get_locale on IOS - OS.get_locale() and TranslationServer.get_locale()
3 participants
@naithar @akien-mga @Calinou