Fix for the sprite display position jumps when placed at subpixel locations and moving the camera #41534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the 2D canvas display positions jumping pseudo randomly when the are located at fractional coordinates and the camera changes location. Fixes godotengine#41491, godotengine#35606 etc. Godot 4.0 branch.
Fixed the static analyzer complain about the whitespace.
m6502
changed the title
m6502
changed the title
Another whitespace...
Calinou
changed the title
Cleaning the fractional part before makes it work even better.
Removing whitespace.
|
Improved the fix for 4.0 too. More info at the 3.2 pull request: #41535 |
|
What is required to get a review of this pull request as to unblock it so it gets merged? |
|
This would need to be rebased to squash commits into one and use a meaningful commit message, see PR workflow and https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind. |
reduz
added a commit
to reduz/godot
that referenced
this pull request
Oct 30, 2020
-Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes godotengine#41814 Solves proposal godotengine/godot-proposals#1666 Supersedes godotengine#35606, supersedes godotengine#41535, supersedes godotengine#41534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the 2D canvas display positions jumping pseudo randomly when the are located at fractional coordinates and the camera changes location. Fixes #41491, fixes #35606 etc. Godot 4.0 branch.