Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio bus effects not deselecting after switching focus in the editor #42035

Closed

Conversation

Vinealius
Copy link
Contributor

@Vinealius Vinealius commented Sep 13, 2020

Make the appropriate selection of the effect on the audio bus.

  • Select an effect on more than one Audio bus the other ones remains selected, so if you press the Delete key you can delete one effect selected at a time of each diferent Audio bus.
  • Create a new node in the scene and create and select a Audio bus effect, then select the new scene node and press the Delete key to delete the node, the effect will be deleted instead.

@Vinealius Vinealius changed the title audio bus effect fixed Audio bus effect fixed Sep 13, 2020
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Sep 13, 2020
@Calinou Calinou added this to the 4.0 milestone Sep 13, 2020
@Vinealius Vinealius force-pushed the audio_bus_effect_fixed branch 2 times, most recently from bb37888 to fe4c9f1 Compare September 16, 2020 17:47
@YuriSizov YuriSizov requested review from a team August 24, 2021 23:32
@Calinou
Copy link
Member

Calinou commented Jun 3, 2022

Thanks for opening a pull request!

Please amend the commit to use a human-readable commit message (git commit --amend). This way, people reading the Git log can easily figure out what's going on 🙂

@fire
Copy link
Member

fire commented Dec 12, 2023

@Calinou is this ready to go? It's more of a usability rather than audio change.

@Calinou Calinou force-pushed the audio_bus_effect_fixed branch from fe4c9f1 to f223567 Compare December 12, 2023 23:09
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 41365c6), it works as expected.

Before

Don't mind the stretching, I forgot to disable resizing in SimpleScreenRecorder and it ignores aspect ratio.

simplescreenrecorder-2023-12-13_00.07.01.mp4

After (this PR)

simplescreenrecorder-2023-12-13_00.06.26.mp4

@Calinou
Copy link
Member

Calinou commented Dec 12, 2023

@Calinou is this ready to go? It's more of a usability rather than audio change.

I've force-pushed an updated commit message, so this should be good to merge now.

@akien-mga akien-mga changed the title Audio bus effect fixed Fix audio bus effects not deselecting after switching focus in the editor Dec 13, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Dec 13, 2023
@YuriSizov
Copy link
Contributor

Superseded by #85879. Thanks for your contribution nevertheless.

@YuriSizov YuriSizov closed this Dec 14, 2023
@YuriSizov YuriSizov removed this from the 4.3 milestone Dec 14, 2023
@YuriSizov YuriSizov added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual bug : AudioEffect don't deselect if only one effect per bus
6 participants