-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audio bus effects not deselecting after switching focus in the editor #42035
Conversation
bb37888
to
fe4c9f1
Compare
Thanks for opening a pull request! Please amend the commit to use a human-readable commit message ( |
@Calinou is this ready to go? It's more of a usability rather than audio change. |
fe4c9f1
to
f223567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (rebased on top of master
41365c6), it works as expected.
Before
Don't mind the stretching, I forgot to disable resizing in SimpleScreenRecorder and it ignores aspect ratio.
simplescreenrecorder-2023-12-13_00.07.01.mp4
After (this PR)
simplescreenrecorder-2023-12-13_00.06.26.mp4
I've force-pushed an updated commit message, so this should be good to merge now. |
Superseded by #85879. Thanks for your contribution nevertheless. |
Make the appropriate selection of the effect on the audio bus.