Fix Bullet prioritised list of Areas a RigidBody is a member of element shift. #42061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaCatania
approved these changes
Sep 15, 2020
|
Thanks! |
This was referenced Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when shifting the elements in the prioritised list of
Areas aRigidBodyis intersecting with, the shifting is done in the wrong order. Therefore, all elements past the insertion point are replaced with the element at the insertion point. This effectively removesAreas from the list ofAreas a body is intersecting with. In addition, it doesn't trigger updates to theAreaSpace Overridemodifiers when theRigidBodyleaves the missingArea.This PR reverses the order the elements are shifted to correctly shift the elements.
Fixes #41743.