Fix import logic for VRAM compressed texture formats #42118
+36
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compressed stream texture now saves right image dimensions for every compression format. Also it allows to compressor resize image on it's side to make it more optimized. So ETC1 format becames smaller then before. Pvrtc format always saves square texture.
akien-mga
force-pushed
the
fix_pvrtc_2
branch
from
ec5523f
to
344d97b
Compare
|
I force pushed a rebase as this included a CHANGELOG update unrelated to this PR (due to me force-pushing the CHANGELOG to fix the 3.2.3 release date). I also amended the commit message to be clearer about what it does, and removed the references to the issues which are handled in #38076. |
akien-mga
changed the title
akien-mga
added
topic:import
and removed
platform:ios
topic:porting
topic:rendering
labels
|
Are you able to review your changes. Master added etcpak and some things have been shifted. Edited: I forgot this was 3.x. Please ignore. |
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3
to
c58391c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugsquad edit: Fixes #38040, fixes #35851.
Compressed stream texture now saves right image dimensions for every compression format.
Also it allows to compressor resize image on it's side to make it more optimized.
So ETC1 format becames smaller then before. Pvrtc format always saves square texture.