Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement add_directly to animation tree node add2 and add3 #42302

Closed
wants to merge 1 commit into from
Closed

Implement add_directly to animation tree node add2 and add3 #42302

wants to merge 1 commit into from

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Sep 24, 2020 •
edited
Loading

For #37661

The current algorithm adds the transformations after the subtraction of the difference.
So, for compatibility, I implemented a checkbox to add the transforms directly.

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:core labels Sep 24, 2020
@Calinou Calinou added this to the 4.0 milestone Sep 24, 2020
@Zireael07
Copy link
Contributor

I assume 'directry' in PR title is a typo, right?

@TokageItLab
Copy link
Member Author

TokageItLab commented Sep 24, 2020 •
edited
Loading

Ah sorry, it is miss typo

@TokageItLab TokageItLab changed the title Implement add_directry to animation tree node add2 and add3 Implement add_directly to animation tree node add2 and add3 Sep 24, 2020
@TokageItLab TokageItLab reopened this Sep 30, 2020
@TokageItLab
Copy link
Member Author

I cleaned up commits

@akien-mga akien-mga requested a review from reduz December 27, 2020 16:09
@TokageItLab TokageItLab requested a review from a team as a code owner January 7, 2021 14:59
@TokageItLab TokageItLab mentioned this pull request Jan 20, 2021
Closed
@josefkaragoli josefkaragoli mentioned this pull request May 8, 2021
Closed
@fire
Copy link
Member

fire commented Jun 28, 2021

Wanted to check for mergability, but the pr needs an update.

@TokageItLab TokageItLab marked this pull request as draft September 5, 2021 18:59
@rafallus rafallus mentioned this pull request Oct 16, 2021
Open
@Calinou Calinou removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 16, 2021
@TokageItLab
Copy link
Member Author

TokageItLab commented Oct 17, 2021 •
edited
Loading

Superseded by #53903.

@TokageItLab TokageItLab mentioned this pull request Apr 18, 2022
Closed
@TokageItLab TokageItLab deleted the fix_animation_tree_node_add branch September 16, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
archived enhancement topic:animation topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@TokageItLab @Zireael07 @fire @Calinou @aaronfranke @akien-mga