Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bullet Area overlaps when Area properties or shapes change. #42306

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

madmiraal
Copy link
Contributor

Currently, Areas in Bullet physics only update the CollisionObjects they overlap with when they or the other objects are moved (or created). This PR ensures that Areas are updated and trigger any necessary signals when their properties or shapes change too including:

  • Collision shape enabled or disabled
  • Collision shape added or removed
  • Collision shape properties changed
  • Collision layers changed
  • Collision mask changed
  • Monitoring enabled or disabled
  • Monitorable enabled or disabled (ensures other Areas are updated)

Fixes #22889
Fixes #39947

@FrederickDesimpel
Copy link

Oh, these and other recent physics fixes seem essential, no ? Too bad 3.2.3 just released... Will these then be in 3.2.4, and how long would that take ?

@mrjustaguy
Copy link
Contributor

This Possibly Fixes #32776 too

@madmiraal
Copy link
Contributor Author

#32776 is fixed with #42374.

@madmiraal
Copy link
Contributor Author

Rebased following #42639.

@pouleyKetchoupp pouleyKetchoupp added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 18, 2021
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works fine on 3.x (can't be tested on master at the moment because Bullet is disabled).

@pouleyKetchoupp pouleyKetchoupp merged commit 756eab2 into godotengine:master Nov 18, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 18, 2021
@madmiraal madmiraal deleted the fix-39947 branch November 19, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants