[macOS] Fix mouse position in captured mode. #42327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 25, 2020
|
Thanks! |
jamie-pate
reviewed
Sep 28, 2020
| const NSRect contentRect = [wd.window_view frame]; | ||
| NSRect pointInWindowRect = NSMakeRect(contentRect.size.width / 2, contentRect.size.height / 2, 0, 0); | ||
| NSPoint pointOnScreen = [[wd.window_view window] convertRectToScreen:pointInWindowRect].origin; | ||
| CGPoint lMouseWarpPos = { pointOnScreen.x, CGDisplayBounds(CGMainDisplayID()).size.height - pointOnScreen.y }; |
There was a problem hiding this comment.
Is it not possible to stack displays vertically in MacOS?
There was a problem hiding this comment.
Or am I misinterpreting the reason behind this code
There was a problem hiding this comment.
It's possible to arrange displays vertically, but it does not matter. This code is needed to convert coordinates to global space (which is relative to the upper-left corner of the main display).
There was a problem hiding this comment.
I have checked it with vertically aligned displays just to be sure, it works fine.
|
What about the case of setting the mouse position when tabbing out and in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move mouse cursor to the center of main window when switching to captured mode (similar to Linux and Windows behavior).
Fixes: #42321