Add custom background line colour to TextEdit and remove marked lines #42775
Conversation
Paulb23
force-pushed
the
code_edit_line_background
branch
from
2648cf6 to
643ed20
Compare
Paulb23
force-pushed
the
code_edit_line_background
branch
from
643ed20 to
c5b9874
Compare
Paulb23
force-pushed
the
code_edit_line_background
branch
from
c5b9874 to
4340f9f
Compare
Paulb23
force-pushed
the
code_edit_line_background
branch
from
4340f9f to
6f18d9e
Compare
| text_editor->add_theme_color_override("completion_existing_color", EDITOR_GET("text_editor/highlighting/completion_existing_color")); | ||
| text_editor->add_theme_color_override("completion_scroll_color", EDITOR_GET("text_editor/highlighting/completion_scroll_color")); | ||
| text_editor->add_theme_color_override("completion_font_color", EDITOR_GET("text_editor/highlighting/completion_font_color")); | ||
| text_editor->add_theme_color_override("font_color", EDITOR_GET("text_editor/highlighting/text_color")); |
There was a problem hiding this comment.
It's worth noting that font_color and font_color_selected are the only theme items whose name differs from the matching editor setting (text_color and text_selected_color). Do we want to harmonize them?
There was a problem hiding this comment.
font_color is like our default font color property in a lot of controls 🤔 But text_color makes more sense for this particular editor setting. I'd keep it.
Though font_color_selected should be changed to font_selected_color or selection_font_color.
There was a problem hiding this comment.
Nice catch should been font_selected_color.
Yeah text sounds better to me, though only for the editor, don't want to make TextEdit itself have a different naming scheme to the rest of the controls.
Paulb23
force-pushed
the
code_edit_line_background
branch
from
6f18d9e to
00e10a8
Compare
|
Thanks! |
Separating this from my WIP branch as part of #31739
Added a way to set/get the background colour of a line, the background colour is now drawn on the minimap. This supersedes marked lines which have been removed.
During the process I cleaned up some duplicated theme loading code between each of the editors.
closes #34165
closes godotengine/godot-proposals/issues/987