Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document more NavigationMesh properties #42974

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Document more NavigationMesh properties #42974

merged 1 commit into from
Mar 23, 2021

Conversation

skyace65
Copy link
Contributor

Adds a description for Agent Height, Agent Radius and Cell Height.

@skyace65 skyace65 requested a review from a team as a code owner October 21, 2020 19:51
@Calinou Calinou added this to the 4.0 milestone Oct 21, 2020
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after applying the suggestion.

@@ -87,8 +88,10 @@
The maximum angle a slope can be at for navigation to be generated on it.
</member>
<member name="agent/radius" type="float" setter="set_agent_radius" getter="get_agent_radius" default="0.6">
Determines where the edge of a navigation mesh is so an agent will not overlap with another mesh, or stand over nothing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Determines where the edge of a navigation mesh is so an agent will not overlap with another mesh, or stand over nothing.
Determines where the edge of a navigation mesh is. This way, an agent will not overlap with another mesh or stand over nothing.

@skyace65
Copy link
Contributor Author

Fixed

@akien-mga akien-mga requested a review from Calinou March 23, 2021 12:23
@akien-mga akien-mga dismissed Calinou’s stale review March 23, 2021 12:23

Changes done.

@akien-mga akien-mga merged commit cdafcc3 into godotengine:master Mar 23, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants