Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Array for node configuration warnings #43180

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Use Array for node configuration warnings #43180

merged 1 commit into from
Apr 12, 2021

Conversation

nathanfranke
Copy link
Contributor

Previously, the warnings were passed as a string and delimitation of which were hard coded at each implementation.

@nathanfranke nathanfranke requested a review from a team as a code owner October 29, 2020 10:03
akien-mga
akien-mga reviewed Oct 29, 2020
View reviewed changes
scene/main/node.cpp Outdated Show resolved Hide resolved
akien-mga
akien-mga reviewed Oct 29, 2020
View reviewed changes
scene/main/node.cpp Outdated Show resolved Hide resolved
akien-mga
akien-mga reviewed Oct 29, 2020
View reviewed changes
scene/main/node.cpp Outdated Show resolved Hide resolved
akien-mga
akien-mga reviewed Oct 29, 2020
View reviewed changes
scene/main/node.cpp Outdated Show resolved Hide resolved
@nathanfranke nathanfranke force-pushed the node-configuration-array branch 3 times, most recently from 6cae029 to 67b4464 Compare October 29, 2020 12:19
@Calinou Calinou added this to the 4.0 milestone Oct 29, 2020
@Calinou Calinou mentioned this pull request Mar 28, 2021
Open
@nathanfranke nathanfranke requested review from a team as code owners April 12, 2021 04:10
@nathanfranke
Copy link
Contributor Author

nathanfranke commented Apr 12, 2021 •
edited
Loading

Rebased & Fixed formatting errors, should be fine as long as some weird build doesn't fail 😅
Edit: Also fixed some awkward wording in the docs

@nathanfranke
Use Array for node configuration warnings
2a8c59c 
Previously, the warnings were passed as a string and delimitation of which were hard coded at each implementation.
@akien-mga akien-mga merged commit cee5414 into godotengine:master Apr 12, 2021
@akien-mga
Copy link
Member

Thanks!

@nathanfranke nathanfranke deleted the node-configuration-array branch April 12, 2021 08:49
@pouleyKetchoupp pouleyKetchoupp mentioned this pull request Apr 14, 2021
Merged
@nathanfranke nathanfranke mentioned this pull request Sep 12, 2022
Open
@kleonc kleonc mentioned this pull request Nov 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xrayez Xrayez Xrayez left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nathanfranke @akien-mga @Xrayez @Calinou