SceneTree: Fix reparent crash with animation tracks renaming disabled #43497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check was there since the first commit in 2014, but a later feature added in 2018 with godotengine#17717 did not properly update the code while adding non animation-related code in `perform_node_renames`. Fixes godotengine#40532.
akien-mga
added
bug
topic:editor
crash
cherrypick:3.x
|
@jesperkondrup Could you test this build from the Especially to check that it doesn't break when reparenting nodes which are used in animation tracks with the |
|
@akien-mga Everything works in that build. I can move the sprite1 into another node with the sprite1 name without problems (it just gets renamed now) and I can also add it to an Animation player and still move it back and forth between nodes without problems. |
|
Thanks for testing! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was there since the first commit in 2014, but a later feature added in 2018
with #17717 did not properly update the code while adding non animation-related code
in
perform_node_renames.Fixes #40532.