doc: Sync classref with Variant utility methods #43612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Nov 17, 2020
| @@ -695,9 +704,9 @@ struct VariantUtilityFunctions { | |||
| return p_arr.hash(); | |||
| } | |||
|
|
|||
| static inline Variant instance_from_id(int64_t p_id) { | |||
| static inline Object *instance_from_id(int64_t p_id) { | |||
There was a problem hiding this comment.
@reduz I guess it's fine to return Object * directly? That's what the GDScript method does, and it seems to compile fine.
akien-mga
commented
Nov 17, 2020
| @@ -829,22 +838,18 @@ static _FORCE_INLINE_ Variant::Type get_ret_type_helper(void (*p_func)(P...)) { | |||
| static void call(Variant *r_ret, const Variant **p_args, int p_argcount, Callable::CallError &r_error) { \ | |||
| call_helperr(VariantUtilityFunctions::m_func, r_ret, p_args, r_error); \ | |||
| } \ | |||
| \ | |||
There was a problem hiding this comment.
I know this goes against the usual policy but in such macro code, I figure it might be best to keep things compat and avoid empty lines with a trailing \. The alternative would have been to add the missing separation lines + trailing \ but it didn't feel right.
Copied relevant documentation from the original `@GDScript` built-ins, which will likely be removed in a future commit. Various fixups to `variant_utility.cpp` while working on this.
akien-mga
force-pushed
the
variant-utils-doc
branch
from
8fee78b to
c6dcf33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied relevant documentation from the original
@GDScriptbuilt-ins,which will likely be removed in a future commit.
Various fixups to
variant_utility.cppwhile working on this.