Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix test_body_motion() sometimes failing to extracting collision information #43617

Open
wants to merge 6 commits into
base: 3.x
Choose a base branch
from
Open

[3.x] Fix test_body_motion() sometimes failing to extracting collision information #43617

wants to merge 6 commits into from
+1,139 −1,482

Commits on Jan 16, 2021

  1. Refactor Godot Space2D and Space3D 

    Removes duplicated code, unnecessary loops and unnecessary checks.
Adds missing checks and generates appropriate errors.
    @madmiraal
    madmiraal committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    3123577 View commit details
    Browse the repository at this point in the history

  2. Remove SPACE_PARAM_TEST_MOTION_MIN_CONTACT_DEPTH 

    To ensure that collision information is extracted and possible motion
is precise, the minimum contact depth must be 0. Therefore, there is no
need for this parameter.
    @madmiraal
    madmiraal committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    fee10be View commit details
    Browse the repository at this point in the history

  3. Remove minimum depth checks from Godot collision solvers 

    Ensures callback is always called.
Enables callback to control minimum depth checks.
    @madmiraal
    madmiraal committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    80509eb View commit details
    Browse the repository at this point in the history

  4. Do not treat zero rectangle or cube overlaps as collisions

    @madmiraal
    madmiraal committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    b6af82d View commit details
    Browse the repository at this point in the history

  5. Refactor the Godot GJK EPA API to extract all GJK EPA result information

    @madmiraal
    madmiraal committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    e91351c View commit details
    Browse the repository at this point in the history

  6. Make CollisionSolverSW::solve_distance return distance 

    Generate appropriate error messages if it fails.
    @madmiraal
    madmiraal committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    e2553e5 View commit details
    Browse the repository at this point in the history