Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ccd enabled by default on Bullet bodies #43801

Merged
merged 1 commit into from
Dec 3, 2020

Commits on Nov 25, 2020

  1. Fixed ccd enabled by default on Bullet bodies

    It was due to main_shape_changed being called two times for each
    added body. The first time it disables ccd, which sets the internal ccd
    threshold to be 10000. The second time, it enables ccd again because
    the internal threshold is > 0.
    
    Bodies are now consistently set with a ccd threshold of 0 when ccd is
    disabled.
    
    This was causing crashing asserts in Bullet when adding bodies in some
    scenarios, in btVector3::normalize():
    btAssert(!fuzzyZero());
    
    These crashes will still happen with ccd enabled.
    pouleyKetchoupp committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    faca8b7 View commit details
    Browse the repository at this point in the history