Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put misc. 3D tool visible instances on their own layer #43896

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

RandomShaper
Copy link
Member

This makes that visible stuff invisible to ReflectionProbes, whose preview in the editor shouldn't involve them.

Otherwise you get this in the editor (not a big deal, but neither desirable):

image
image


This code is generously donated by IMVU.

This makes that visible stuff invisible to ReflectionProbes, whose preview in the editor shouldn't involve them.
@akien-mga
Copy link
Member

Can this be used to fix #8485 / #8140?

@RandomShaper
Copy link
Member Author

Good question, but I don't think so.

@JFonS
Copy link
Contributor

JFonS commented Nov 27, 2020

They are separate issues. Post-process effects are applied after everything is rendered to the viewport, by then any information on the render layer is already lost.

In order to keep gizmos unaffected by post-processing we would have to render the scene first, apply the effects, and then render the gizmos on top of that. But that would create other problems with transparent gizmos and effects that distort the original scene.

@akien-mga akien-mga merged commit a84ad91 into godotengine:master Dec 3, 2020
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_rel_probe_vis branch December 3, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants