Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CanvasItem's hide signal to hidden #44189

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Rename CanvasItem's hide signal to hidden #44189

merged 1 commit into from
Dec 8, 2020

Conversation

madmiraal
Copy link
Contributor

Part of #16863.

@madmiraal madmiraal added this to the 4.0 milestone Dec 8, 2020
@madmiraal madmiraal requested a review from a team as a code owner December 8, 2020 10:05
@madmiraal madmiraal force-pushed the canvasitem-hidden-signal branch from cedbad0 to 82a1077 Compare December 8, 2020 12:08
@madmiraal madmiraal force-pushed the canvasitem-hidden-signal branch from 82a1077 to 4330283 Compare December 8, 2020 12:14
@akien-mga akien-mga merged commit 3846a37 into godotengine:master Dec 8, 2020
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus mentioned this pull request Dec 8, 2020
Closed
83 tasks
@madmiraal madmiraal deleted the canvasitem-hidden-signal branch December 8, 2020 13:18
akien-mga added a commit to akien-mga/godot that referenced this pull request Dec 9, 2020
@akien-mga
Fix connections to CanvasItem and Tabs signals
9a8e123 
Follow-up to godotengine#44188 and godotengine#44189.
@akien-mga akien-mga mentioned this pull request Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:codestyle topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@madmiraal @akien-mga