Added ability to have Tabs in TabContainer at bottom #44420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could potentially add the option to toggle this for the editor tab containers, in the popup with changing dock positions and "make floating". |
Exposed this functionality to GD Script (as expected). Some cleanup was also done with the default and editor themes. Also simplified some logic to remove unneccesary duplication of code and nested if/else statements.
EricEzaM
force-pushed
the
PR/tab-container-tabs-at-bottom
branch
from
6cb6ce5
to
e9ff3b9
Compare
|
Rebased. Updated video in OP |
YuriSizov
reviewed
Oct 1, 2021
|
I noticed that in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed this functionality to GD Script (as expected).
Images for the "bottom" tabs were added to the default theme. The editor theme was also changed to have the option of using bottom-aligned tabs. The textures added are just the existing textures flipped upside down.
Also simplified some logic to remove unnecessary duplication of code and nested if/else statements.
bY7KGEmHUb.mp4
Closes godotengine/godot-proposals#1986