Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Control rotation to rotation_degrees #44607

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Rename Control rotation to rotation_degrees #44607

merged 1 commit into from
Dec 28, 2020

Conversation

madmiraal
Copy link
Contributor

@madmiraal madmiraal commented Dec 23, 2020 •
edited
Loading

Currently, Control's rect_rotation property is in degrees. This PR renames it to rect_rotation_degrees to match Node2D's rotation_degrees, and creates a new rect_rotation property, which uses radians.

Part of #16863.

@madmiraal madmiraal added this to the 4.0 milestone Dec 23, 2020
@madmiraal madmiraal requested a review from a team as a code owner December 23, 2020 07:14
@madmiraal madmiraal mentioned this pull request Dec 23, 2020
Closed
83 tasks
akien-mga
akien-mga approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for consistency with Node2D, but @reduz will open a proposal to handle radians/degrees differently in 4.0.

@akien-mga akien-mga merged commit 891b1cd into godotengine:master Dec 28, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-control-rotation branch December 29, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@madmiraal @akien-mga