Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use normal_map #44614

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

madmiraal
Copy link
Contributor

As originally identified here, normal map is two words; so properties and methods should use normal_map instead of normalmap. Currently, Godot uses a mixture of these. This PR ensures that references to normal maps are consistently normal_map.

Part of #16863.

@akien-mga
Copy link
Member

Needs a rebase, otherwise good to merge.

@madmiraal madmiraal force-pushed the rename-normalmap-normal_map branch from 53a797c to b4a190e Compare December 29, 2020 08:04
@madmiraal
Copy link
Contributor Author

Rebased following #44401.

@akien-mga akien-mga merged commit 2086acf into godotengine:master Dec 29, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-normalmap-normal_map branch December 29, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants