-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDNative: Fix symbols visibility for GCC #44671
Conversation
Are there any news regarding this PR? |
Would it be useful to add something similar to the godot/modules/gdnative/include/gdnative/gdnative.h Lines 38 to 53 in 51d6891
|
I could be completely wrong but that may be a left over from earlier times, don't we statically link GDNative modules in iOS? Or has that changed since I last used GDNative in iOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use GCC myself so i can't test it but this change seems sound. Functions marked as GDN_EXPORT need to be set to visible so if GCC does not do so by default then this seems like the right way to fix it to me.
Thanks! |
Could it be backported to 3.2? |
Yes, that's what the |
Cherry-picked for 3.2.4. |
I'm building native library with CMake and found out default visibility settings make it unusable with Godot because symbols are hidden.
This PR makes exported functions visible when compiling them with GCC.
Copy of godotengine/godot-headers#81