Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize class variables with default values in servers/ #44813

Closed
wants to merge 50 commits into from
Closed

Initialize class variables with default values in servers/ #44813

wants to merge 50 commits into from

Conversation

valdaarhun
Copy link

@valdaarhun valdaarhun commented Dec 30, 2020 •
edited
Loading

Part of #43636

As of now, I have only finished working on the files in the servers/audio/ directory.

@Calinou Calinou added this to the 4.0 milestone Dec 30, 2020
@valdaarhun valdaarhun marked this pull request as ready for review January 8, 2021 12:26
@valdaarhun valdaarhun marked this pull request as draft January 8, 2021 12:34
@valdaarhun
Copy link
Author

The checks seem to have failed because of certain changes in the code. I am going to start working on fixing them now.

bruvzg
bruvzg reviewed Jan 9, 2021
View reviewed changes
servers/text_server.h Outdated Show resolved Hide resolved
@valdaarhun
Copy link
Author

valdaarhun commented Jan 22, 2021 •
edited
Loading

@qarmin I have applied the patch and reverted the changes. All the build checks have passed. Thanks!

@akien-mga
Copy link
Member

I have yet to do an in-depth review (will try to do so ASAP), but note that before this can be merged, the commits should all be squashed into one (instead of 40 currently). See PR workflow.

@qarmin qarmin mentioned this pull request Mar 2, 2021
Closed
@valdaarhun
Copy link
Author

Hi. I am really sorry for the late response. I have been very busy with college work for the last one month. I'll try to complete this issue ASAP.

@valdaarhun valdaarhun requested review from a team as code owners May 6, 2021 09:18
@valdaarhun
Copy link
Author

I have fixed all the conflicts in this branch while there are still conflicts in PR #46602. Should I continue working on this branch or should I wait for the conflicts to get resolved in the other branch?

@valdaarhun valdaarhun closed this Sep 27, 2021
@valdaarhun
Copy link
Author

valdaarhun commented Sep 27, 2021 •
edited
Loading

Closed this PR in accordance with PR #46602.

@valdaarhun valdaarhun deleted the server_init branch September 27, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg left review comments

@qarmin qarmin qarmin requested changes

Assignees
No one assigned
Labels
archived bug topic:codestyle topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@valdaarhun @qarmin @akien-mga @bruvzg @Calinou @mbrlabs @madmiraal