Rename color constants (alternative) #45144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
Jan 13, 2021
aaronfranke
reviewed
Jan 13, 2021
dalexeev
force-pushed
the
color-consts
branch
from
8552854 to
aca6ff5
Compare
aaronfranke
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
All of this looks good to me, awesome work!
As for the conflicting color names listed in the OP, IMO all are good as they are in this PR, but ("Seashell" and "SEASHELL") vs ("SeaShell" and "SEA_SHELL") should be up to the community. To me neither is obviously better, and these conflict between the X11 and .NET color names. If I had to pick one, "Seashell" seems quite common, and it's not the color of a shell over the sea (but rather shells of animals in the sea) so I guess that's an argument against "Sea Shell".
Named color constants renamed to UPPERCASE. Unlike godotengine#41019, this PR is complete and implements these changes in the simplest way possible. Co-authored-by: Shivam Mukherjee <mshivam98@gmail.com>
dalexeev
force-pushed
the
color-consts
branch
from
aca6ff5 to
a97f1a3
Compare
|
I think we should follow X11 fully (the only exception is the added |
akien-mga
approved these changes
May 7, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named color constants renamed to UPPERCASE. Unlike #41019, this PR
is complete and implements these changes in the simplest way possible.
I believe the underscores issue was solved quite elegantly (without introducing an extra function as in the original PR). I didn't even have to modify the
variant_call.cppfile. And it works correctly.Also, I compared the naming in different places and filled this into a table (color_consts.ods.zip). It remains to resolve the following naming conflicts (we have to decide who we give preference to, MS or X11):
BURLY_WOODBURLYWOODBurlyWoodBurlywood.NETX11Details
The difficulty is that we have taken these names from two sources. There is no color in MS documentation for
REBECCA_PURPLE,WEB_GRAY,WEB_GREEN,WEB_MAROON,WEB_PURPLE, there is no colorTRANSPARENTin the Wikipedia page. In theory, the wiki page takes precedence, but in C# some color names are spelled differently. The question is what we should be compatible with. In my opinion, internal compatibility is more important than compatibility with the standard C# class.I think we should adhere to the following naming scheme:
Color.LIGHT_SEA_GREEN— constant in GDScript.Colors.LightSeaGreen— constant in C#.Light sea green color.— description of the constant in the docs.Therefore, if the documentation says "Seashell color.", Then the constant should be named
Color.SEASHELLin GDScript andColors.Seashellin C#. Otherwise, the description should be "Sea shell color." and the constant should be namedColor.SEA_SHELLandColors.SeaShell.@aaronfranke Could you review this, please?