Fixed popup not calculating size correctly before adjusting its rect. #45201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the correct behavior of popups should be that if they don't fit their rect on screen, they shift their origin so that their bottom-left corner is placed at cursor (compared to just moving the popup up by the excessive height right now). Would that be "easy enough" to implement? |
|
You are quite right... I can look into it. |
|
I think this can be merged for now, as the above request should be another PR. This fix would be needed for that implementation anyway I think. |
YeldhamDev
approved these changes
Feb 28, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not regress the fix from #44906
Fixes #45199 (see my comment in this issue for further details)
MenuButton popups still full width:
Popups correctly fit into window:
