Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML5] Better editor persistent folders, automatically open zip import popup #45705

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Feb 4, 2021

In this PR:

  • Usual RasterizerDummy sync.
  • [Editor] Import zip via drag and drop in project manager (still not working on HTML5 because the file is not used immediately).
    Dropping a single ZIP file in the project manager will now prompt the import dialog.
  • [HTML5] Make home (/home/web_user) path persistent in editor.
    We used to only persist specific sub-folders of /home/web_user/ when running the Web Editor.
    This resulted in bad UX about default project creation path etc.
    This PR makes the whole folder persistent, move the zip preloading to a different folder (to avoid persisting it), and automatically prompt the user to import it if present.

dropimport

Fixes #44754 .
Note: As mentioned above, only preloading works on HTML5, not drag and drop of the zip file from your file system.

Dropping a single ZIP file in the project manager will now prompt the
import dialog.
We used to only persist specific sub-folder of /home/web_user/ when
running the Web Editor. This resulted in bad UX about default project
creation path etc.
This PR makes the whole folder persistent, move the zip preloading to a
different folder (to avoid persisting it), and automatically prompt the
user to import it if present.
@akien-mga akien-mga merged commit 5e0f3f1 into godotengine:master Feb 4, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Online/Web Editor Default Project Directory is bad
2 participants