Display loading text while the project manager is loading #45785
Conversation
Calinou
added
enhancement
topic:editor
cherrypick:3.x
This hints the user that the project manager is currently busy loading the project. This is important for the HTML5 editor as the current feedback isn't very obvious. This also removes the unused `_exit_dialog` function.
Calinou
force-pushed
the
project-manager-add-loading-text
branch
from
90461e8
to
8be5125
Compare
|
Unnecessary on desktop and the placement of the text feels out of place. |
I don't think it hurts to have on desktop either. Most of the time, you'll see it for less than 1 second anyway. This could be moved to a progress dialog of some kind, but EditorProgress isn't usable in the project manager as far as I know (and often tries to be doing too much for what we need to do here). |
| @@ -2015,6 +2015,10 @@ void ProjectManager::_confirm_update_settings() { | |||
| } | |||
|
|
|||
| void ProjectManager::_open_selected_projects() { | |||
| // Show loading text to tell the user that the project manager is busy loading. | |||
| // This is especially important for the HTML5 project manager. | |||
| loading_label->set_modulate(Color(1, 1, 1)); | |||
There was a problem hiding this comment.
I don't see any code that would actually hide it again once it finished loading?
There was a problem hiding this comment.
@akien-mga The project manager quits as soon as the project is starting to be opened. Therefore, there should be no need to hide the text.
|
Thanks! |
|
It's not trivial to cherry-pick, so a dedicated PR would be good. |
Calinou
removed
the
cherrypick:3.x
masterversion of #46026.This hints the user that the project manager is currently busy loading the project. This is important for the HTML5 editor as the current feedback isn't very obvious.
This also removes the unused
_exit_dialogfunction (also unused in3.2).Preview