Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize class variables with default values in scene/ [2/2] #45845

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Initialize class variables with default values in scene/ [2/2] #45845

merged 1 commit into from
Feb 10, 2021

Conversation

qarmin
Copy link
Contributor

@qarmin qarmin commented Feb 9, 2021

Latest part of #43636

@qarmin qarmin added this to the 4.0 milestone Feb 9, 2021
@qarmin qarmin requested a review from bruvzg as a code owner February 9, 2021 13:25
akien-mga
akien-mga reviewed Feb 9, 2021
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the few comments I left.

Very tedious to review it all, I can't imagine how long it took to do all those changes, but thanks for doing it!

scene/gui/popup_menu.h Show resolved Hide resolved
scene/gui/progress_bar.h Outdated Show resolved Hide resolved
scene/gui/tab_container.h Outdated Show resolved Hide resolved
scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
scene/gui/text_edit.h Outdated Show resolved Hide resolved
scene/main/viewport.cpp Outdated Show resolved Hide resolved
scene/resources/material.cpp Outdated Show resolved Hide resolved
scene/resources/style_box.h Outdated Show resolved Hide resolved
scene/resources/style_box.h Outdated Show resolved Hide resolved
scene/resources/visual_shader.h Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit e8f7312 into godotengine:master Feb 10, 2021
@akien-mga
Copy link
Member

Thanks!

@qarmin qarmin deleted the cppcheck_scene_2 branch February 11, 2021 05:36
@madmiraal madmiraal mentioned this pull request Feb 13, 2021
Closed
This was referenced Feb 13, 2021
Closed
Merged
akien-mga
akien-mga reviewed Mar 2, 2021
View reviewed changes
scene/resources/animation.h
enabled = true;
}
bool imported = false;
bool enabled = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this on review, but this changed the default value from true to false.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #46585.

akien-mga added a commit to akien-mga/godot that referenced this pull request Mar 2, 2021
@akien-mga
Fix Animation tracks disabled by default
f49433c 
Was a regression from godotengine#45845.
@akien-mga akien-mga mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg Awaiting requested review from bruvzg

Assignees
No one assigned
Labels
bug topic:codestyle
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@qarmin @akien-mga