Keep Hue value when Saturation or Value is zero #46230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
KoBeWi
approved these changes
Feb 21, 2021
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ColorPicker, when Saturation or Value slider is zero, The UV and W box is reset to red. And the hue slider won't work.
This happened when color was set from sliders. Then the UV and W boxes need to update after the color changes. The received new HSV values are converted from the new RGB color. If R == G == B (Gray), The original hue value is lost.
This PR updating HSV from slider values directly to avoid to lost the original hue value.
Should help solve some bug in #46110.