Switch to 4 point 4th order optimal resampling for wavs #46245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellenhp
force-pushed
the
resampling_wavs
branch
from
6c634fe
to
929abd4
Compare
akien-mga
added
the
cherrypick:3.x
akien-mga
added
archived
and removed
cherrypick:3.x
|
Superseded by #51082. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports over the resampling algorithm from #46086 to wav files.
Unlike the issue with mp3s and oggs, I've been unable to reproduce any resampling artifacts in wav file resampling even when I force resampling to occur by using wavs that use weird sample rates. This is really odd to me because wavs use linear interpolation instead of cubic like mp3s and oggs did (until recently). And I could very easily hear a difference for oggs and mp3s. To be perfectly honest, without being able to repro the bug I don't think it makes sense to merge this PR, but I'm sending it out anyway because I said I would and I try to stick to my promises 😄 There's also an argument to be made that we should use the same algorithm everywhere like @Calinou said. Plus a lot of the bugs complaining about resampling artifacts make a point to mention it happens with wavs as well. So maybe doing this is a good idea? Not sure.
Notes on the changes:
I think I adjusted
DATA_PADcorrectly to account for the increased distance I'm looking backwards in the buffer, but I'm not sure of that so I'd appreciate a reviewer taking a critical look at that particular change. Also, perhaps I should be using look-ahead instead of look-behind here?This should fix #40630 also. I fixed the mono ogg issue in an earlier PR so I think we can call that issue done once the resampling artifacts are taken care of.