Add Various ColorPicker shapes

[gongpha]

Introduce more choices of ColorPicker. The settings are available in property and editor settings.

Edit : I think this is enough for usability.

[gongpha]

The thing that makes me surprised is when color is overbright . . .

[Calinou]

Do we really need to implement all the ColorPicker shapes out there? This could end up making the ColorPicker a huge class.

To me, it seems the most useful/desired ColorPicker shape is the good old HSV wheel. It solves most issues that the old square picker shape has.

[gongpha]

Do we really need to implement all the ColorPicker shapes out there? This could end up making the ColorPicker a huge class.

To me, it seems the most useful/desired ColorPicker shape is the good old HSV wheel. It solves most issues that the old square picker shape has.

I'm gonna re-think and edit this draft to dump out some TODO. And you just posted recently ^^

I know this is enough for editor usability, Not like painting software.

[YeldhamDev]

A spacing at the bottom of the circles to separate it from the current color would make it look better.

[fire]

You need to convert to lab colour. If you're around we can chat on discord.

Edited:

Or rocket chat.

Edited:

I'll be on in 8 hours.

[gongpha]

@fire I prefer to use Discord. gongpha#0238

[groud]

Globally, the code looks ok to me.
I think the feature is good to have, the ColorPicker node is used outside of the editor itself, so I'd say it make sense to allow for such modification if needed.

[fire]

I have updated the PickerShapeType to default to SHAPE_VHS_CIRCLE and rebased on master.

[groud]

I have updated the PickerShapeType to default to SHAPE_VHS_CIRCLE and rebased on master.

I think the SHAPE_HSV_WHEEL would be a better fit. It's more common and easier to use.

Have you seen with OP first? It's not common and practical to force-push changes to someone else's branch.

[fire]

I did a rebase and set the Picker to SHAPE_VHS_CIRCLE, but it seems like there's disagreement. So I'll probably go with the consensus.

My personal preference is to also add HSY' because it deals with > 1.0 values better as shown earlier.

https://wolthera.info/2014/07/hsi-and-hsy-for-kritas-advanced-colour-selector/

[fire]

@gongpha Feel free to take control again.

[groud]

LGTM

[fire]

Looks good to me.

[akien-mga]

Thanks!

[YuriSizov]

Note: this PR introduced a regression in the editor (and likely in user projects to a degree) because it creates shaders in the constructor of the ColorPicker control (so 2 new shaders per each created control). In the editor this causes slowdowns/hitching when updating the Inspector dock, likely the more color pickers are involved, the more it hitches.

A fix is in works.