Renaming rendering/2d project settings. #46552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rendering/quality/2d section of project settings is becoming considerably expanded in 3.2.4, and arguably was not the correct place for settings that were not really to do with quality. 3.2.4 is the last sensible opportunity we will have to move these settings, as the only existing one likely to break compatibility in a small way is `pixel_snap`, and given that the whole snapping area is being overhauled we can draw attention to the fact it has changed in the release notes. Class reference is also updated and slightly improved. `pixel_snap` is renamed to `gpu_pixel_snap` in the project settings and code to help differentiate from CPU side transform snapping.
|
Nice, I suggest to announce like a rework on the pixel snaps to improve 'Pixel Art Games', that would call the attention to many users to review their settings. Because there are two new options, and the existing one was renamed. Right now I saw in https://godotengine.org/article/release-candidate-godot-3-2-4-rc-3 |
akien-mga
approved these changes
Mar 1, 2021
|
Thanks! |
|
Where is the transform snap option? |
|
They were reverted in #46657. See the linked post for more discussion. For an example of one way of doing pixel snapped 2d retro games, see https://github.com/lawnjelly/godot-snapping-demo. |
Elephant34
added a commit
to Elephant34/godot-docs
that referenced
this pull request
Aug 4, 2021
Changed the tip on how to enable pixel snapping as it changed in 3.3 (see godotengine/godot#46552)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rendering/quality/2dsection of project settings is becoming considerably expanded in 3.2.4, and arguably was not the correct place for settings that were not really to do with quality.3.2.4 is the last sensible opportunity we will have to move these settings, as the only existing one likely to break compatibility in a small way is
pixel_snap, and given that the whole snapping area is being overhauled we can draw attention to the fact it has changed in the release notes.Class reference is also updated and slightly improved.
pixel_snapis renamed togpu_pixel_snapin the project settings and code to help differentiate from CPU side transform snapping.Notes
pixel_snapsetting will need to setgpu_pixel_snapin the new 2d tab to get the same behaviour.use_nvidia_workaroundalso changes, but few people will effectively be using this now that batching is the default for GLES2 and GLES3.pixel_snapandtransform_snap. Renaming togpu_pixel_snapis a compromise to try and differentiate the two. It will probably require a page in the documentation to fully go over these options once everything is finalized.