Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2][HTML5] Replace XMLHttpRequest(s) with Fetch. #46731

Merged
merged 4 commits into from
Mar 6, 2021
Merged

[3.2][HTML5] Replace XMLHttpRequest(s) with Fetch. #46731

merged 4 commits into from
Mar 6, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Mar 6, 2021

3.2 version of #46728 (use Fetch API to load the engine and to implement HTTPClient).

Faless added 4 commits March 5, 2021 17:32
@Faless
[HTML5] Preloader fetch, streaming instantiation.
f64ec5f
@Faless
[HTML5] Export process writes sizes in template.
41c6453 
This allow the loading bar to be much more reliable, even in cases where
realible stream loading status is not detectable (server-side
compression, chunked encoding).
@Faless
[HTML5] Rename heapCopy to heapSlice.
751a6f9 
New heapCopy function copies a TypedArray to the heap.
@Faless
[HTML5] Replace XMLHttpRequest with Fetch.
c01f35d 
This has some advantages:
- Streaming/chunked response support.
- Broader headers support.
@Faless Faless added this to the 3.2 milestone Mar 6, 2021
@Faless Faless requested a review from a team as a code owner March 6, 2021 13:56
@akien-mga akien-mga merged commit 82fcd3a into godotengine:3.2 Mar 6, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Mar 29, 2021
Closed
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
@Calinou Calinou mentioned this pull request May 28, 2021
Closed
@Faless Faless deleted the js/3.x_fetch_world branch June 3, 2021 17:35
@Calinou Calinou mentioned this pull request Jun 21, 2021
Closed
@Calinou Calinou mentioned this pull request Nov 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:web topic:network topic:porting
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Faless @akien-mga