[3.3] Fix capsule-cylinder collision in godot physics #47085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test specific axes before falling back to GJK-EPA algorithm to get more accurate separation axes for common cases, the same way it's done for cylinder-cylinder collision.
akien-mga
approved these changes
Mar 17, 2021
akien-mga
reviewed
Mar 17, 2021
|
|
||
| // Cylinder edge against capsule balls. | ||
|
|
||
| Vector3 capsule_A_axis = p_transform_a.basis.get_axis(2); |
There was a problem hiding this comment.
You're using get_axis(1) in the master PR, and get_axis(2) here. Is that expected?
There was a problem hiding this comment.
Comparing more of the two files it seems to be a common pattern so I guess it's on purpose.
There was a problem hiding this comment.
Yeah it's on purpose. It's because capsules have been changed to vertical direction on master.
akien-mga
approved these changes
Mar 17, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test specific axes before falling back to GJK-EPA algorithm to get more accurate separation axes for common cases, the same way it's done for cylinder-cylinder collision.
Fixes issues from #47067 (comment) & #47067 (comment)
3.3 backport of PR #47084