Improved 3D Scene Importer #47166
Merged
Improved 3D Scene Importer #47166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
previously requested changes
Mar 19, 2021
fire
reviewed
Mar 19, 2021
| @@ -893,12 +893,13 @@ void Window::_window_input(const Ref<InputEvent> &p_ev) { | |||
| } | |||
|
|
|||
| if (exclusive_child != nullptr) { | |||
| /* | |||
There was a problem hiding this comment.
What was the reasoning for this removal?
There was a problem hiding this comment.
I see no reason for it, and makes the built-in mode unusable
There was a problem hiding this comment.
Then why this code is commented out not removed? Such code is usually never used again and just litters the codebase.
There was a problem hiding this comment.
no, this will need more through inspection, I have an idea why it is there but it is causing problems, it needs to be replaced by something else, but prefer to do after this is merged.
YeldhamDev
previously requested changes
Mar 19, 2021
reduz
force-pushed
the
improve-scene-import
branch
from
5856e83
to
9657a9d
Compare
akien-mga
reviewed
Mar 22, 2021
akien-mga
reviewed
Mar 22, 2021
akien-mga
approved these changes
Mar 22, 2021
* Added option for importers to show an Advanced settings dialog * Created advanced settings dialog for Scene Importer * Cleaned up importers (remove many old/unused options) * Added the ability to customize every node, material, mesh and animation individually * Saving to animations and meshes to files is now a manual process, making it more predictable * Added the ability for materials to be replaced by external files (or to be made external, up to you). * When doubleclicking an impoted scene in the filesystem dock, it automatically shows the import settings instead of asking to open it. WARNING: Lightmap UV unwrap is not working, it needs to be re-made.
reduz
force-pushed
the
improve-scene-import
branch
from
9657a9d
to
97a3a66
Compare
|
Thanks! |
aaronfranke
reviewed
Mar 23, 2021
This was referenced Mar 27, 2021
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements godotengine/godot-proposals#1823
WARNING: Lightmap UV unwrap is not working, it needs to be re-made.