Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded names in generated objects #47271

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Remove hardcoded names in generated objects #47271

merged 1 commit into from
Mar 22, 2021

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Mar 22, 2021

When a node is added to the scene, it is automatically assigned the correct name depending on the node naming scheme settings. So if I understand correctly, calling set_name doesn't make any sense.

Closes #35690.

@Shatur Shatur requested a review from a team as a code owner March 22, 2021 20:42
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning this is a good change is because we have default generated node names and when we override the default it should give additional information. The current design doesn't give additional information.

@akien-mga akien-mga added this to the 4.0 milestone Mar 22, 2021
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 22, 2021
@akien-mga akien-mga merged commit 89d3c78 into godotengine:master Mar 22, 2021
@akien-mga
Copy link
Member

Thanks!

@Shatur Shatur deleted the remove-hardcoded-names branch March 22, 2021 22:42
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent object name for generated collision
4 participants