Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] VariantParser: NaN, INF read/write bug fixed #47500

Merged

Conversation

briansemrau
Copy link
Contributor

3.x version of #47497.

Fixes #40589

@briansemrau briansemrau requested a review from a team as a code owner March 30, 2021 15:27
@Calinou Calinou added this to the 3.4 milestone Mar 30, 2021
@briansemrau
Copy link
Contributor Author

briansemrau commented Oct 5, 2021

Updated to match changes in #47497 per comments.

Verified that this saves/loads scenes with inf, -inf, and nan values.

@akien-mga akien-mga changed the title NaN, INF read/write bug fixed (rebased, 3.x) [3.x] VariantParser: NaN, INF read/write bug fixed Oct 5, 2021
@briansemrau
Copy link
Contributor Author

(Pushed empty changes to re-trigger checks stuck on "Queued")

@akien-mga akien-mga merged commit c637588 into godotengine:3.x Oct 5, 2021
@akien-mga
Copy link
Member

Thanks!

@briansemrau briansemrau deleted the nan-inf-tscn-parsing-bug-3.x branch October 25, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants