Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed debug code #47561

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Removed debug code #47561

merged 1 commit into from
Apr 2, 2021

Conversation

szymonm-google
Copy link
Contributor

@szymonm-google szymonm-google commented Apr 2, 2021 •
edited
Loading

Removed true || part from if (true || ...) check.

@szymonm-google szymonm-google requested a review from a team as a code owner April 2, 2021 03:10
BastiaanOlij
BastiaanOlij approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobrainer imho, as far as the discussion on godotchat went looks like Reduz was testing and never removed the true.
It makes sense to use the color format provided.

@akien-mga akien-mga added this to the 4.0 milestone Apr 2, 2021
@akien-mga akien-mga merged commit 8610867 into godotengine:master Apr 2, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@szymonm-google @akien-mga @BastiaanOlij