Chose format from supported ones that we support

[BastiaanOlij]

Check the available formats against formats we support to choose the first match. Basically we want to skip sRGB formats as we're doing the linear -> sRGB color correction ourselves. sRGB formats will do a hardware conversion which doubles this and causes the screen to look washed out.

We may wish to add more supported formats.

This may fix #47585

[BastiaanOlij]

Note that besides adding more formats to the supported formats list we may wish to order this list from the formats we wish to use and swap the two for loops around. This way we determine priority, not the Vulkan driver which may turn out to just return the list in value order.

edit I'm going to swap the order, hang on

[akien-mga]

This may fix #47585

I confirm that this fixes the issue for me with both Intel HD 630 and Radeon RX Vega M running on Mesa 21.1.

[BastiaanOlij]

One footnote after discussions with Reduz, we expect most if not all GPUs support VK_FORMAT_B8G8R8A8_UNORM so that will likely be selected by default.

If VK_FORMAT_R8G8B8A8_UNORM ends up being selected there may be other changes that are required. We'll need to deal with that when someone runs into it.

Same if someone runs into No usable surface format found. we'll need to investigate which formats are supported on that device and see if we can add it to the allowed_formats list.

[akien-mga]

Thanks!