Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different icons for revertable instanced properties in the inspector #47782

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Apr 10, 2021

Properties modified from their default value (but otherwise unmodified from the instanced/inherited scene) will display a non-clickable asterisk icon as well.

This closes godotengine/godot-proposals#2581.

Some questions:

  • Should the instanced revert icon have a different icon color? It's not that easy to distinguish at a glance right now. I made it have a "dashed" appearance to mimic the PackedScene's "movie clap" icon.
  • Should the asterisk icon be slightly faded out? It can't be clicked after all (I already disabled the hover feedback for it).

Preview

Base scene

image

Inherited scene

Flip H was manually unchecked.

image

Properties modified from their default value (but otherwise unmodified
from the instanced/inherited scene) will display a non-clickable
asterisk icon as well.
@Calinou Calinou requested a review from a team as a code owner April 10, 2021 21:59
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Apr 10, 2021
@Calinou Calinou added this to the 4.0 milestone Apr 10, 2021
@YeldhamDev
Copy link
Member

I like the asterisk one, but the new reload icon looks too detailed for its size, and kinda ugly as a result.

@groud
Copy link
Member

groud commented Apr 12, 2021

I am not strictly against a change here, but do we really need to make a distinction between "real default values" and "default values by inheritance"? I am not sure I understand problem to solve behind this. For me, the "revert to default value" simply mean reverting to the inherited class default value, so the distinction between the two does not seem very necessary.

Maybe another solution might be to simply find a way to notify that a property was modified in the hierarchy. Like by changing the font color to red or something like that? That's more or less what the asterisk does but in a more subtle way I guess?

@reduz
Copy link
Member

reduz commented Jul 29, 2022

I understand the good intention here but I think this is bad usability. The revert icon works very well even if you cant distinguish between scenarios. Changing this will make it worse for more people than those who it helps.

@Calinou
Copy link
Member Author

Calinou commented Oct 31, 2022

Closing due to lack of support.

@Calinou Calinou added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Oct 31, 2022
@Calinou Calinou closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use different "reset" icons for instanced scene properties in the inspector
4 participants