Allow warning-ignore in the same line as the respective warning

[mphe]

This patch allows putting warning-ignore comments in the same line as the respective warning itself.

# warning-ignore: return_value_discarded
connect("tree_entered", self, "_tree_entered")

# This works now, too
connect("tree_entered", self, "_tree_entered")  # warning-ignore: return_value_discarded

I can't think of any particular reason the latter shouldn't be allowed.
It should be up to the programmer to decide where to put their comments.
Personally, and I'm sure I'm not the only one, I find the latter more readable as it doesn't visually interrupt the actual code.

I took a look at the source and saw that this fix only requires a >= to be changed to >, so this is a very simple fix for slightly more flexibility.
As for the master branch, I couldn't find any code related to honoring warning-ignore at all, so this fix is only for 3.x versions.

[akien-mga]

Is this also relevant for the master branch?

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[mphe]

Is this also relevant for the master branch?

As mentioned in the top post, I haven't found any warning-ignore related code in the master branch. I don't know if it was renamed or still needs to be implemented (or maybe I'm just blind), but it probably can't be trivially merged into master.

[akien-mga]

Indeed, thanks for checking. It seems that this code was lost in the rewrite, there's some stray stuff left but no logic to bind it together:

$ rg ignored_warnings
modules/gdscript/gdscript_parser.cpp
241:    if (ignored_warnings.has(warn_name)) {

modules/gdscript/gdscript_parser.h
1202:   Set<String> ignored_warnings;

$ rg warning-ignore
editor/plugins/script_text_editor.cpp
298:            code_editor->get_text_editor()->insert_at("# warning-ignore:" + meta["code"].operator String(), meta["line"].operator int64_t() - 1);

[akien-mga]

Cherry-picked for 3.3.2.