Rename get_surface_material to get_surface_override_material #47878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
surface material
property ofMeshInstance3D
s overrides theMaterial
for a given surface. It behaves the same asoverride_material
just on a per-surface basis. This has been poorly communicated to users who often mix upMeshInstance3D.get_surface_material()
withMesh.surface_get_material()
. This becomes especially problematic when users set a material on the mesh and then try to get it from the MeshInstance3D as in #31558Renaming the property to reflect that it is an override material is consistent with the
override_material
property of GeometryInstance3D and makes it clear that it is not the same things as a mesh materialPartially implements: godotengine/godot-proposals#2589
Implements: #31558 (comment)