Fix forgotten rename on surface material override

[BastiaanOlij]

Just a rename of a propertie that was overlooked in the getter/setter of Meshinstance

Fixes #47913

[akien-mga]

There's one more occurrence of material/, should it be changed too?

$ rg '"material/'
scene/3d/mesh_instance_3d.cpp
54:     if (p_name.operator String().begins_with("material/")) {
78:     if (p_name.operator String().begins_with("material/")) {

scene/scene_string_names.cpp
194:            mesh_materials[i] = "material/" + itos(i);

[BastiaanOlij]

There's one more occurrence of material/, should it be changed too?

$ rg '"material/'
scene/3d/mesh_instance_3d.cpp
54:     if (p_name.operator String().begins_with("material/")) {
78:     if (p_name.operator String().begins_with("material/")) {

scene/scene_string_names.cpp
194:            mesh_materials[i] = "material/" + itos(i);

I don't think this is related, I think that is the normal material property on meshes

[akien-mga]

Actually it seems to be dead code?

$ rg mesh_materials
scene/scene_string_names.h
222:    StringName mesh_materials[MAX_MATERIALS];

scene/scene_string_names.cpp
194:            mesh_materials[i] = "material/" + itos(i);

Nothing uses it.

Edit: Made a PR: #47916.

[akien-mga]

Thanks!

[clayjohn]

Whoops! Thanks for cleaning up after me :)