Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix errors related to joints setup with two non-dynamic bodies #47943

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

pouleyKetchoupp
Copy link
Contributor

Abort 2D and 3D joints setup when none of the bodies is dynamic to avoid mathematical problems that lead to cryptic error messages.

Joints can still become valid when body types change, that's why creating the joints in the first place is still supported.

Fixes #47478
Fixes #47872 (comment)

3.x backport of #47942

@pouleyKetchoupp pouleyKetchoupp added this to the 3.4 milestone Apr 16, 2021
@pouleyKetchoupp pouleyKetchoupp requested a review from a team April 16, 2021 01:00
@akien-mga akien-mga merged commit a706fb1 into godotengine:3.x Apr 28, 2021
@akien-mga
Copy link
Member

Thanks!

@pouleyKetchoupp pouleyKetchoupp deleted the joint-check-body-types-3.x branch April 28, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants