Fix CSGMesh undo not refreshing gizmo
#48174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmiraal
added
bug
topic:core
cherrypick:3.x
akien-mga
approved these changes
Apr 25, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
added
cherrypick:3.3
and removed
cherrypick:3.x
|
Cherry-picked for 3.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified here, when undoing the selected
Meshin aCSGMesh, the gizmo is not fully removed. This PR ensures that the gizmo is updated when the assignedMeshof an existingCSGMeshis changed.