Revert "Fix hints on PhysicsMaterial bounce/friction." #48321
Conversation
This reverts commit 6c18bae.
|
Maybe we should also improve the documentation for these properties to clarify what values they can take (e.g. which range preserves conservation of energy, and what clamping happens behind the scenes which can modify the input values). |
There was a problem hiding this comment.
See my comment on range hints.
Also as a note, PhysicalBone3D has its own properties for friction and bounce and enforces values in 0..1 range. It would be better to make things consistent and use PhysicalMaterial there too, but that's a bit out of the scope of this PR.
| ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "friction", PROPERTY_HINT_RANGE, "0,1,0.01"), "set_friction", "get_friction"); | ||
| ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "friction"), "set_friction", "get_friction"); | ||
| ADD_PROPERTY(PropertyInfo(Variant::BOOL, "rough"), "set_rough", "is_rough"); | ||
| ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "bounce", PROPERTY_HINT_RANGE, "0,1,0.01"), "set_bounce", "get_bounce"); | ||
| ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "bounce"), "set_bounce", "get_bounce"); |
There was a problem hiding this comment.
It makes sense to let users set higher values, but ,or_greater should be added instead of removing the range entirely, since negative values are not useful (rough and absorbent are meant to be used instead and their effect is documented) and the interval 0..1 is still a good hint for common cases.
There was a problem hiding this comment.
This is purely a revert of #42203 to fix the regression. I think any new changes should be made in a separate PR, where they can be discussed, agreed (or left unmerged due to a lack of consensus) and, if necessary, reverted if they're wrong.
There was a problem hiding this comment.
I see no point in reverting the PR myself, since by far for most use cases it is useful and an improvement over what was in there. I would do a separate PR with or_greater hint for the rare cases where you really want to go over 1.0.
There was a problem hiding this comment.
I've just opened #48434 to add or_greater hint instead of reverting the range.
|
Superseded by #48434. |
Reverts #42203
Fixes #48298