Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation following implementation of particle trails #48345

Merged
merged 1 commit into from
May 1, 2021

Conversation

madmiraal
Copy link
Contributor

Ran --doctool . following merge of #48242.

@madmiraal madmiraal added this to the 4.0 milestone May 1, 2021
@madmiraal madmiraal requested a review from a team as a code owner May 1, 2021 08:59
doc/classes/RibbonTrailMesh.xml Show resolved Hide resolved
doc/classes/GPUParticles3D.xml Show resolved Hide resolved
@madmiraal madmiraal force-pushed the fix-48242-docs branch 2 times, most recently from f330f4a to a9bf740 Compare May 1, 2021 12:04
@madmiraal madmiraal requested a review from a team as a code owner May 1, 2021 12:04
@akien-mga akien-mga merged commit 33a0fb6 into godotengine:master May 1, 2021
@akien-mga
Copy link
Member

Thanks!

BTW now that we have a working solution for software rendering of Vulkan, I plan to add a CI build (or most likely a step in an existing build, no need to rebuild everything twice) that runs --doctool and checks if there's any changes missed in the PR.

So we can ensure that PRs at least sync the template for their changes - and ideally that contributors write the documentation for the new APIs.

@madmiraal madmiraal deleted the fix-48242-docs branch May 1, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants